-
Notifications
You must be signed in to change notification settings - Fork 48
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support ES 7.17.7 #456
Support ES 7.17.7 #456
Conversation
@nfsantos Can you also add this branch name here: https://github.com/alexklibisz/elastiknn/blob/main/.github/workflows/ci.yml#L6 Then it should actually run the CI. |
I added the branch |
I see now. You also need to remove this line: https://github.com/alexklibisz/elastiknn/blob/cross-build-7.17.6/.github/workflows/ci.yml#L108 Sorry for all the trouble. I'll keep an eye out for your change to move it along quickly. I would change it myself but I don't have access to write to your branch. |
Done |
Hmm, pypi publish is failing. Maybe move the "publish plugin from ..." steps above the pypi step to unblock. |
It turns out I can edit your branch, so I I'm trying the thing I just suggested. |
Thanks! |
This is failing in some interesting ways. Sorry. If you're in a big rush, I think you could also just run the assembly commands locally, produce a zip file, and maintain it internally. I'll try to figure out what it's complaining about later today. |
For now I just ran the release manually and created https://github.com/alexklibisz/elastiknn/releases/tag/7.17.7.0 |
That manual release does the trick for us. Just a small question. The 7.17.7.0 binary is marked as pre-release. Does this mean that in the future you plan on changing the binary of this release? Asking this because we store a checksum of the binary, to make sure we are downloading the right thing, so if the binary changes in the future, it will break our build. |
I went ahead and marked it as a non-pre-release. It won't change. I'll think more about how to support 7.x and 8.x going forward. |
Ok, that will do fine for the time being. Hopefully, it will be some time until there is a 7.17.8 release. |
Hi @alexklibisz and @nfsantos, |
Related issue
Changes
Support for Elasticsearch 7.17.7.